Require UTF-8 in Utf8Pattern::StringPattern#156556
Merged
rust-bors[bot] merged 1 commit intoMay 16, 2026
Merged
Conversation
rustbot
added
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
cc @ChrisDenton |
ChrisDenton
reviewed
May 14, 2026
qaijuang
force-pushed
the
issue-156491-str-replace-utf8-pattern
branch
from
6c9dd5f to
efc95b4
Compare
ChrisDenton
approved these changes
May 15, 2026
qaijuang
force-pushed
the
issue-156491-str-replace-utf8-pattern
branch
from
efc95b4 to
8909e79
Compare
Member
|
Thanks! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 15, 2026
…utf8-pattern, r=ChrisDenton Require UTF-8 in `Utf8Pattern::StringPattern` Store `&str` instead, so the UTF-8 invariant is enforced at the API boundary. Fixes rust-lang#156491
rust-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2026
…uwer Rollup of 6 pull requests Successful merges: - #155360 (map_try_insert changes) - #156493 (actually run the temp_dir doctest) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156577 (Test EII UI tests with prefer-dynamic) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 15, 2026
…utf8-pattern, r=ChrisDenton Require UTF-8 in `Utf8Pattern::StringPattern` Store `&str` instead, so the UTF-8 invariant is enforced at the API boundary. Fixes rust-lang#156491
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 15, 2026
…utf8-pattern, r=ChrisDenton Require UTF-8 in `Utf8Pattern::StringPattern` Store `&str` instead, so the UTF-8 invariant is enforced at the API boundary. Fixes rust-lang#156491
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 15, 2026
…utf8-pattern, r=ChrisDenton Require UTF-8 in `Utf8Pattern::StringPattern` Store `&str` instead, so the UTF-8 invariant is enforced at the API boundary. Fixes rust-lang#156491
rust-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2026
…uwer Rollup of 8 pull requests Successful merges: - #156493 (actually run the temp_dir doctest) - #156452 (Implement pinned drop sugar) - #156600 (Make const param default test reproduce original ICE) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156577 (Test EII UI tests with prefer-dynamic) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.) - #156587 (Correctly handle associated items in rustdoc macro expansion)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
May 15, 2026
…utf8-pattern, r=ChrisDenton Require UTF-8 in `Utf8Pattern::StringPattern` Store `&str` instead, so the UTF-8 invariant is enforced at the API boundary. Fixes rust-lang#156491
rust-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2026
Rollup of 11 pull requests Successful merges: - #148788 (Unconstrained parameter fix) - #153238 (debuginfo: slices are DW_TAG_array_type's) - #155521 (Add lint againts invalid runtime symbol definitions) - #156319 (Require EIIs to be defined when we compile a rust dylib) - #156452 (Implement pinned drop sugar) - #156600 (Make const param default test reproduce original ICE) - #156493 (actually run the temp_dir doctest) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.) - #156587 (Correctly handle associated items in rustdoc macro expansion)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 15, 2026
…utf8-pattern, r=ChrisDenton Require UTF-8 in `Utf8Pattern::StringPattern` Store `&str` instead, so the UTF-8 invariant is enforced at the API boundary. Fixes rust-lang#156491
rust-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2026
…uwer Rollup of 12 pull requests Successful merges: - #153238 (debuginfo: slices are DW_TAG_array_type's) - #156319 (Require EIIs to be defined when we compile a rust dylib) - #156452 (Implement pinned drop sugar) - #156554 (Allow user-provided `llvm_args` to override target spec arguments) - #156571 (Disable `main_needs_argc_argv` for Wasm) - #156600 (Make const param default test reproduce original ICE) - #156493 (actually run the temp_dir doctest) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.) - #156587 (Correctly handle associated items in rustdoc macro expansion) - #156604 (coverage: Reduce and clarify the context-mismatch test case)
rust-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2026
…uwer Rollup of 12 pull requests Successful merges: - #148788 (Unconstrained parameter fix) - #156319 (Require EIIs to be defined when we compile a rust dylib) - #156452 (Implement pinned drop sugar) - #156554 (Allow user-provided `llvm_args` to override target spec arguments) - #156571 (Disable `main_needs_argc_argv` for Wasm) - #156600 (Make const param default test reproduce original ICE) - #156493 (actually run the temp_dir doctest) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.) - #156587 (Correctly handle associated items in rustdoc macro expansion) - #156604 (coverage: Reduce and clarify the context-mismatch test case)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store
&strinstead, so the UTF-8 invariant is enforced at the API boundary.Fixes #156491